diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index 2922da501efb..9151560ce6b9 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -327,7 +327,7 @@ jobs: runner: ${{fromJson(needs.Runner-Preparation.outputs.matrix-HIP)}} name: Integration-Tests (${{matrix.runner[1] == 'gfx90a' && 'mi210' || 'mi300x'}}) container: - image: rocm/pytorch:rocm6.1_ubuntu22.04_py3.10_pytorch_2.4 + image: rocmshared/pytorch:rocm6.2.2_ubuntu22.04_py3.10_pytorch_2.5.1_asan options: --device=/dev/kfd --device=/dev/dri --security-opt seccomp=unconfined --group-add video --user root steps: - name: Checkout @@ -396,22 +396,15 @@ jobs: mkdir -p ~/.ccache du -h -d 1 ~/.ccache - - name: Update PATH - run: | - echo "/opt/rocm/llvm/bin" >> $GITHUB_PATH - - name: Install pip dependencies - run: | - python3 -m pip install --upgrade pip - python3 -m pip install lit - - name: Install apt dependencies + - name: Update compiler to clang run: | - apt update - apt install ccache + export CC=/usr/bin/clang + export CXX=/usr/bin/clang++ - name: Install Triton id: amd-install-triton run: | echo "PATH is '$PATH'" - pip uninstall -y triton + pip uninstall -y triton pytorch-triton-rocm cd python ccache --zero-stats pip install -v -e '.[tests]' diff --git a/.github/workflows/integration-tests.yml.in b/.github/workflows/integration-tests.yml.in index 7de7264272c1..6d72b65207dc 100644 --- a/.github/workflows/integration-tests.yml.in +++ b/.github/workflows/integration-tests.yml.in @@ -374,7 +374,7 @@ jobs: name: Integration-Tests (${{matrix.runner[1] == 'gfx90a' && 'mi210' || 'mi300x'}}) container: - image: rocm/pytorch:rocm6.1_ubuntu22.04_py3.10_pytorch_2.4 + image: rocmshared/pytorch:rocm6.2.2_ubuntu22.04_py3.10_pytorch_2.5.1_asan options: --device=/dev/kfd --device=/dev/dri --security-opt seccomp=unconfined --group-add video --user root steps: @@ -388,25 +388,16 @@ jobs: - *restore-build-artifacts-step - *inspect-cache-directories-step - - name: Update PATH - run: | - echo "/opt/rocm/llvm/bin" >> $GITHUB_PATH - - - name: Install pip dependencies - run: | - python3 -m pip install --upgrade pip - python3 -m pip install lit - - - name: Install apt dependencies + - name: Update compiler to clang run: | - apt update - apt install ccache + export CC=/usr/bin/clang + export CXX=/usr/bin/clang++ - name: Install Triton id: amd-install-triton run: | echo "PATH is '$PATH'" - pip uninstall -y triton + pip uninstall -y triton pytorch-triton-rocm cd python ccache --zero-stats pip install -v -e '.[tests]' diff --git a/third_party/proton/csrc/lib/Profiler/RocTracer/RoctracerProfiler.cpp b/third_party/proton/csrc/lib/Profiler/RocTracer/RoctracerProfiler.cpp index adc908d2cd96..ca93678e1c82 100644 --- a/third_party/proton/csrc/lib/Profiler/RocTracer/RoctracerProfiler.cpp +++ b/third_party/proton/csrc/lib/Profiler/RocTracer/RoctracerProfiler.cpp @@ -74,6 +74,7 @@ std::shared_ptr convertActivityToMetric(const roctracer_record_t *activity) { std::shared_ptr metric; switch (activity->kind) { + case kHipVdiCommandTask: case kHipVdiCommandKernel: { if (activity->begin_ns < activity->end_ns) { metric = std::make_shared( @@ -135,7 +136,7 @@ void processActivity(RoctracerProfiler::CorrIdToExternIdMap &corrIdToExternId, const roctracer_record_t *record, bool isAPI, bool isGraph) { switch (record->kind) { - case 0x11F1: // Task - kernel enqueued by graph launch + case kHipVdiCommandTask: case kHipVdiCommandKernel: { processActivityKernel(corrIdToExternId, externId, dataSet, record, isAPI, isGraph); @@ -169,6 +170,7 @@ std::pair matchKernelCbId(uint32_t cbId) { case HIP_API_ID_hipModuleLaunchCooperativeKernel: case HIP_API_ID_hipModuleLaunchCooperativeKernelMultiDevice: case HIP_API_ID_hipGraphExecDestroy: + case HIP_API_ID_hipGraphInstantiateWithFlags: case HIP_API_ID_hipGraphInstantiate: { isRuntimeApi = true; break; @@ -300,6 +302,13 @@ void RoctracerProfiler::RoctracerProfilerPimpl::apiCallback( pImpl->StreamToCaptureCount[Stream]++; break; } + case HIP_API_ID_hipGraphInstantiateWithFlags: { + hipGraph_t Graph = data->args.hipGraphInstantiateWithFlags.graph; + hipGraphExec_t GraphExec = + *(data->args.hipGraphInstantiateWithFlags.pGraphExec); + pImpl->GraphExecToGraph[GraphExec] = Graph; + break; + } case HIP_API_ID_hipGraphInstantiate: { hipGraph_t Graph = data->args.hipGraphInstantiate.graph; hipGraphExec_t GraphExec = *(data->args.hipGraphInstantiate.pGraphExec);