Skip to content

Commit

Permalink
[AMD] Upgrade AMD CI docker image (#5230)
Browse files Browse the repository at this point in the history
This commits updates the CI to use a new docker image that
contains ROCm 6.2.2 with ASan support and PyTorch 2.5.1.

This also switches to ubuntu's default clang toolchain instead
of using the one which comes with ROCm.
  • Loading branch information
AlexAUT authored Nov 27, 2024
1 parent e7a0561 commit dbebe10
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 26 deletions.
17 changes: 5 additions & 12 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ jobs:
runner: ${{fromJson(needs.Runner-Preparation.outputs.matrix-HIP)}}
name: Integration-Tests (${{matrix.runner[1] == 'gfx90a' && 'mi210' || 'mi300x'}})
container:
image: rocm/pytorch:rocm6.1_ubuntu22.04_py3.10_pytorch_2.4
image: rocmshared/pytorch:rocm6.2.2_ubuntu22.04_py3.10_pytorch_2.5.1_asan
options: --device=/dev/kfd --device=/dev/dri --security-opt seccomp=unconfined --group-add video --user root
steps:
- name: Checkout
Expand Down Expand Up @@ -396,22 +396,15 @@ jobs:
mkdir -p ~/.ccache
du -h -d 1 ~/.ccache
- name: Update PATH
run: |
echo "/opt/rocm/llvm/bin" >> $GITHUB_PATH
- name: Install pip dependencies
run: |
python3 -m pip install --upgrade pip
python3 -m pip install lit
- name: Install apt dependencies
- name: Update compiler to clang
run: |
apt update
apt install ccache
export CC=/usr/bin/clang
export CXX=/usr/bin/clang++
- name: Install Triton
id: amd-install-triton
run: |
echo "PATH is '$PATH'"
pip uninstall -y triton
pip uninstall -y triton pytorch-triton-rocm
cd python
ccache --zero-stats
pip install -v -e '.[tests]'
Expand Down
19 changes: 5 additions & 14 deletions .github/workflows/integration-tests.yml.in
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ jobs:
name: Integration-Tests (${{matrix.runner[1] == 'gfx90a' && 'mi210' || 'mi300x'}})

container:
image: rocm/pytorch:rocm6.1_ubuntu22.04_py3.10_pytorch_2.4
image: rocmshared/pytorch:rocm6.2.2_ubuntu22.04_py3.10_pytorch_2.5.1_asan
options: --device=/dev/kfd --device=/dev/dri --security-opt seccomp=unconfined --group-add video --user root

steps:
Expand All @@ -388,25 +388,16 @@ jobs:
- *restore-build-artifacts-step
- *inspect-cache-directories-step

- name: Update PATH
run: |
echo "/opt/rocm/llvm/bin" >> $GITHUB_PATH

- name: Install pip dependencies
run: |
python3 -m pip install --upgrade pip
python3 -m pip install lit

- name: Install apt dependencies
- name: Update compiler to clang
run: |
apt update
apt install ccache
export CC=/usr/bin/clang
export CXX=/usr/bin/clang++

- name: Install Triton
id: amd-install-triton
run: |
echo "PATH is '$PATH'"
pip uninstall -y triton
pip uninstall -y triton pytorch-triton-rocm
cd python
ccache --zero-stats
pip install -v -e '.[tests]'
Expand Down

0 comments on commit dbebe10

Please sign in to comment.