From 45a0c141b76997530c6f62d4e465880516048ed3 Mon Sep 17 00:00:00 2001 From: Tristan Himmelman Date: Mon, 18 May 2015 10:49:49 -0400 Subject: [PATCH 1/2] Added cocoapod and carthage shields --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 1d8e913..11bd1db 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,7 @@ AlamofireObjectMapper ============ +[![CocoaPods](https://img.shields.io/cocoapods/v/AlamofireObjectMapper.svg)](https://github.com/tristanhimmelman/AlamofireObjectMapper) +[![Carthage compatible](https://img.shields.io/badge/Carthage-compatible-4BC51D.svg?style=flat)](https://github.com/Carthage/Carthage) An extension to [Alamofire](https://github.com/Alamofire/Alamofire) which automatically converts JSON response data into swift objects using [ObjectMapper](https://github.com/Hearst-DD/ObjectMapper/). From 20956b397b0047135ea3a9b9ea581be4a4bde542 Mon Sep 17 00:00:00 2001 From: Jean-Pierre Mouilleseaux Date: Wed, 10 Jun 2015 10:42:46 -0700 Subject: [PATCH 2/2] remove copy-frameworks build phase The copy-frameworks build phase embeds the Alamofire and ObjectMapper frameworks within the AlamofireObjectMapper framework - while the configuration works at runtime, it isn't efficient and more importantly, fails App Store submission with errors: ERROR ITMS-90205: contains disallowed nested bundles ERROR ITMS-90206: contains disallowed file 'Frameworks' A host application needs to link against and copy the Alamofire and ObjectMapper frameworks anyways, so in addition to passing App Store submission, this change will also reclaim the 5.5 MB the embedded frameworks would have taken. --- .../project.pbxproj | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/AlamofireObjectMapper.xcodeproj/project.pbxproj b/AlamofireObjectMapper.xcodeproj/project.pbxproj index 8834191..fcce1bd 100644 --- a/AlamofireObjectMapper.xcodeproj/project.pbxproj +++ b/AlamofireObjectMapper.xcodeproj/project.pbxproj @@ -198,7 +198,6 @@ 6AB2A00C1AF26C36001EBB20 /* Sources */, 6AB2A00D1AF26C36001EBB20 /* Frameworks */, 6AB2A00E1AF26C36001EBB20 /* Headers */, - 6A905E411B067F8100884083 /* ShellScript */, ); buildRules = ( ); @@ -322,24 +321,6 @@ }; /* End PBXResourcesBuildPhase section */ -/* Begin PBXShellScriptBuildPhase section */ - 6A905E411B067F8100884083 /* ShellScript */ = { - isa = PBXShellScriptBuildPhase; - buildActionMask = 2147483647; - files = ( - ); - inputPaths = ( - "$(SRCROOT)/Carthage/Build/iOS/Alamofire.framework", - "$(SRCROOT)/Carthage/Build/iOS/ObjectMapper.framework", - ); - outputPaths = ( - ); - runOnlyForDeploymentPostprocessing = 0; - shellPath = /bin/sh; - shellScript = "/usr/local/bin/carthage copy-frameworks"; - }; -/* End PBXShellScriptBuildPhase section */ - /* Begin PBXSourcesBuildPhase section */ 6AB2A00C1AF26C36001EBB20 /* Sources */ = { isa = PBXSourcesBuildPhase;