Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible prompt color on dark terminal background #23800

Closed
wants to merge 1 commit into from

Conversation

Ravenlol119
Copy link

@Ravenlol119 Ravenlol119 commented Oct 16, 2024

Description

This Pull Request modified the InputReader class, it fixes #6190.

Before: Gray Prompt , it has Low Visibility on Dark Backgrounds, or maybe invisible on some dark themes.
eda5b365eac88fa3676bd14b4338a86

Now: Bright Cyan Prompt, Improved Visibility, it can be seen clearly on both dark theme and bright theme.
893d03707f2552cbcd3388cd880d82f

Release notes

The prompt is now displayed in bright cyan, making it more readable on dark backgrounds.

Copy link

cla-bot bot commented Oct 16, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ebyhr
Copy link
Member

ebyhr commented Oct 16, 2024

Could you add the screenshot before&after this change to the PR description?

@Ravenlol119
Copy link
Author

Ravenlol119 commented Oct 16, 2024

Sure

@ebyhr
Copy link
Member

ebyhr commented Oct 23, 2024

Thanks for attaching the screenshot!

I can see the prompt though the PR title is "invisible". I feel there is no need to make it stands out because it is just a prompt which is not so important. I would leave the review to @wendigo who create the issue #6190.

@Ravenlol119
Copy link
Author

@cla-bot check

Copy link

cla-bot bot commented Oct 27, 2024

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla-signed label Oct 27, 2024
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Nov 18, 2024
Copy link

github-actions bot commented Dec 9, 2024

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Improve CLI prompt color on dark terminal background
2 participants