Add a reminder to notify maintainers about SPI changes #19724
Conversation
That way maintainers will have a chance to get to know early about SPI changes, they will be able to respond to them and potentially notify all other affected SPI consumers they know about.
|
First commit looks good |
|
We could have something automatically tag the PR anytime something changes the SPI POM. |
| @@ -212,6 +212,7 @@ | |||
| </item> | |||
| <!-- Backwards incompatible changes since the previous release --> | |||
| <!-- Any exclusions below can be deleted after each release --> | |||
| <!-- Remember to notify to all Trino maintainers before merging backward incompatible SPI changes --> | |||
There was a problem hiding this comment.
This is not a policy we currently have. Please bring this up with the maintainers group if you would like to add this policy.
|
I am sorry, I have should mark this a draft. I posted this to facilitate the discussion. I had no intention to merge it fast. |
Do you mean by posting a comment on github? |
|
Sorry, I meant labels, not tags. For example, we have something that automatically tags PRs as |
No problem. Github is not a good place to have a discussion. I suggest you post on slack group.
I think he means add a label to the issue. |
|
I was under impression that adding tags does not trigger notifications. |
Add a reminder to notify maintainers about SPI changes
That way maintainers will have a chance to get to know early about SPI
changes, they will be able to respond to them and potentially notify all
other affected SPI consumers they know about.