Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TracingHiveMetastore #19712

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Add TracingHiveMetastore #19712

merged 1 commit into from
Nov 15, 2023

Conversation

dain
Copy link
Member

@dain dain commented Nov 12, 2023 •
edited
Loading

Release notes

(X) Release notes are required, with the following suggested text:

# Hive
* Add tracing to metastore access. ({issue}`19712`)

@dain dain requested a review from electrum November 12, 2023 02:16
@cla-bot cla-bot bot added the cla-signed label Nov 12, 2023
@github-actions github-actions bot added tests:hive hive Hive connector labels Nov 12, 2023
@dain dain force-pushed the tracing-hive-metastore branch 3 times, most recently from 23ca724 to b05fee0 Compare November 12, 2023 05:27
@github-actions github-actions bot added the delta-lake Delta Lake connector label Nov 12, 2023
electrum
electrum approved these changes Nov 14, 2023
View reviewed changes
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Outdated Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Outdated Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Outdated Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Outdated Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Outdated Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Outdated Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Outdated Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Outdated Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Outdated Show resolved Hide resolved
electrum
electrum reviewed Nov 14, 2023
View reviewed changes
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Show resolved Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/tracing/TracingHiveMetastore.java Show resolved Hide resolved
@dain dain force-pushed the tracing-hive-metastore branch from b05fee0 to f55c94e Compare November 14, 2023 03:42
@dain dain requested a review from electrum November 14, 2023 04:32
@dain dain force-pushed the tracing-hive-metastore branch from f55c94e to 6485dae Compare November 15, 2023 19:48
@dain dain merged commit ef63a5a into trinodb:master Nov 15, 2023
55 of 56 checks passed
@dain dain deleted the tracing-hive-metastore branch November 15, 2023 22:24
@github-actions github-actions bot added this to the 434 milestone Nov 15, 2023
@mosabua
Copy link
Member

mosabua commented Nov 15, 2023

Should the release notes entry go to Hive only.. or also Iceberg, Delta Lake, and Hudi ?

@mosabua mosabua mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrum electrum electrum approved these changes

Assignees
No one assigned
Labels
cla-signed delta-lake Delta Lake connector hive Hive connector
Milestone
434
Development

Successfully merging this pull request may close these issues.
3 participants
@dain @mosabua @electrum