Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve encapsulation of unsafe code #51

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Improve encapsulation of unsafe code #51

merged 8 commits into from
Nov 26, 2024

Commits on Nov 26, 2024

  1. Improve safety of allocator handling 

    Don't allow mixing alloc and free functions from different allocators to
prevent UB.
    @bjorn3
    bjorn3 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    112522d View commit details
    Browse the repository at this point in the history

  2. Move the source of libbzip2-rs-sys to libbzip2-rs-sys/src

    @bjorn3
    bjorn3 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    b7246f9 View commit details
    Browse the repository at this point in the history

  3. Add read_byte helper to encapsulte unsafety around next_in

    @bjorn3
    bjorn3 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    7b91aab View commit details
    Browse the repository at this point in the history

  4. Add write_byte helper to encapsulte unsafety around next_out

    @bjorn3
    bjorn3 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    b776b92 View commit details
    Browse the repository at this point in the history

  5. Make allocating memory safe

    @bjorn3
    bjorn3 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    42fb321 View commit details
    Browse the repository at this point in the history

  6. Avoid wrapping_sub in a couple of places where underflow should not b… 

    …e possible

This allows catching cases where the underflow happens anyway when debug
assertions are enabled.
    @bjorn3
    bjorn3 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    101aaaa View commit details
    Browse the repository at this point in the history

  7. Fix review comments

    @bjorn3
    bjorn3 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    4cbe1bb View commit details
    Browse the repository at this point in the history

  8. Restore buggy allocator handling when only the c-allocator feature is… 

    … enabled
    @bjorn3
    bjorn3 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    69b0685 View commit details
    Browse the repository at this point in the history