Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now button broken #887

Open
wants to merge 36 commits into
base: dev
Choose a base branch
from
Open

Now button broken #887

wants to merge 36 commits into from

Conversation

TrentonZero
Copy link

This fixes an issue we saw where pressing the "now" button multiple times causes the timezone to shift to an incorrect value.

@trentrichardson
Copy link
Owner

Sorry, I know this has been quite the delay. Thanks for posting your fix, however it seems to cause an issue with this commit applied:

6b9c576

The first timezone example does not work in the docs. Here is how to reproduce:

  • click the input, choose a time, and change the timezone
  • close the picker by clicking Done
  • click the input to open the picker. The timezone dropdown is blank (it should be the timezone chosen in step one)

For now I have left this fix out of dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants