utput format of gatherer 'cibadmin' when requesting 'cib.configuration.crm_config.cluster_property_set'

[angelabriel]

I'm using trento-agent-1.2.0+git.dev25.1671202822.1b38255-150300.1.1.x86_64

I see some data inconsistency in the output of
/usr/bin/trento-agent facts gather --gatherer "cibadmin" --argument "cib.configuration.crm_config.cluster_property_set"

When the cib configuration contains only one property the gatherer returns an object containing an array

{"id":"cib-bootstrap-options","nvpair":[{"id":"cib-bootstrap-options-have-watchdog","name":"have-watchdog","value":true},{"id":"cib-bootstrap-options-dc-version","name":"dc-version","value":"2.1.2+20211124.ada5c3b36-150400.4.6.1-2.1.2+20211124.ada5c3b36"},{"id":"cib-bootstrap-options-cluster-infrastructure","name":"cluster-infrastructure","value":"corosync"},{"id":"cib-bootstrap-options-cluster-name","name":"cluster-name","value":"hacluster"},{"id":"cib-bootstrap-options-stonith-enabled","name":"stonith-enabled","value":true},{"id":"cib-bootstrap-options-stonith-watchdog-timeout","name":"stonith-watchdog-timeout","value":-1.0},{"id":"cib-bootstrap-options-stonith-timeout","name":"stonith-timeout","value":60.0}]}

The cibadmin -Q shows

    <crm_config>
      <cluster_property_set id="cib-bootstrap-options">
        <nvpair id="cib-bootstrap-options-have-watchdog" name="have-watchdog" value="true"/>
        <nvpair id="cib-bootstrap-options-dc-version" name="dc-version" value="2.1.2+20211124.ada5c3b36-150400.4.6.1-2.1.2+20211124.ada5c3b36"/>
        <nvpair id="cib-bootstrap-options-cluster-infrastructure" name="cluster-infrastructure" value="corosync"/>
        <nvpair id="cib-bootstrap-options-cluster-name" name="cluster-name" value="hacluster"/>
        <nvpair name="stonith-enabled" value="true" id="cib-bootstrap-options-stonith-enabled"/>
        <nvpair name="stonith-watchdog-timeout" value="-1" id="cib-bootstrap-options-stonith-watchdog-timeout"/>
        <nvpair name="stonith-timeout" value="60" id="cib-bootstrap-options-stonith-timeout"/>
      </cluster_property_set>
    </crm_config>

When adding a second property with
crm_attribute -v "SOK" -n "hana_PRD_site_srHook_Fulda" -t crm_config -s SAPHanaSR
which is common on a SAPHanaSR cluster using a srHook, the gatherer returns an array and doubles some content

[{"id":"cib-bootstrap-options","nvpair":[{"id":"cib-bootstrap-options-have-watchdog","name":"have-watchdog","value":true},{"id":"cib-bootstrap-options-dc-version","name":"dc-version","value":"2.1.2+20211124.ada5c3b36-150400.4.6.1-2.1.2+20211124.ada5c3b36"},{"id":"cib-bootstrap-options-cluster-infrastructure","name":"cluster-infrastructure","value":"corosync"},{"id":"cib-bootstrap-options-cluster-name","name":"cluster-name","value":"hacluster"},{"id":"cib-bootstrap-options-stonith-enabled","name":"stonith-enabled","value":true},{"id":"cib-bootstrap-options-stonith-watchdog-timeout","name":"stonith-watchdog-timeout","value":-1.0},{"id":"cib-bootstrap-options-stonith-timeout","name":"stonith-timeout","value":60.0},{"id":"SAPHanaSR-hana_PRD_site_srHook_Fulda","name":"hana_PRD_site_srHook_Fulda","value":"SOK"}]},{"id":"SAPHanaSR","nvpair":[{"id":"cib-bootstrap-options-have-watchdog","name":"have-watchdog","value":true},{"id":"cib-bootstrap-options-dc-version","name":"dc-version","value":"2.1.2+20211124.ada5c3b36-150400.4.6.1-2.1.2+20211124.ada5c3b36"},{"id":"cib-bootstrap-options-cluster-infrastructure","name":"cluster-infrastructure","value":"corosync"},{"id":"cib-bootstrap-options-cluster-name","name":"cluster-name","value":"hacluster"},{"id":"cib-bootstrap-options-stonith-enabled","name":"stonith-enabled","value":true},{"id":"cib-bootstrap-options-stonith-watchdog-timeout","name":"stonith-watchdog-timeout","value":-1.0},{"id":"cib-bootstrap-options-stonith-timeout","name":"stonith-timeout","value":60.0},{"id":"SAPHanaSR-hana_PRD_site_srHook_Fulda","name":"hana_PRD_site_srHook_Fulda","value":"SOK"}]}]

The cibadmin -Q shows:

    <crm_config>
      <cluster_property_set id="cib-bootstrap-options">
        <nvpair id="cib-bootstrap-options-have-watchdog" name="have-watchdog" value="true"/>
        <nvpair id="cib-bootstrap-options-dc-version" name="dc-version" value="2.1.2+20211124.ada5c3b36-150400.4.6.1-2.1.2+20211124.ada5c3b36"/>
        <nvpair id="cib-bootstrap-options-cluster-infrastructure" name="cluster-infrastructure" value="corosync"/>
        <nvpair id="cib-bootstrap-options-cluster-name" name="cluster-name" value="hacluster"/>
        <nvpair name="stonith-enabled" value="true" id="cib-bootstrap-options-stonith-enabled"/>
        <nvpair name="stonith-watchdog-timeout" value="-1" id="cib-bootstrap-options-stonith-watchdog-timeout"/>
        <nvpair name="stonith-timeout" value="60" id="cib-bootstrap-options-stonith-timeout"/>
      </cluster_property_set>
      <cluster_property_set id="SAPHanaSR">
        <nvpair id="SAPHanaSR-hana_PRD_site_srHook_Fulda" name="hana_PRD_site_srHook_Fulda" value="SOK"/>
      </cluster_property_set>
    </crm_config>

My expectation was to get an array of 'properties' even that only one property is available. And each 'property' contains an array of related 'nvpair' elements. But it seems that at the moment all 'nvpair' entries are mixed together.
Or having an object holding the 'properties' with the 'property name' as key and an array of the related 'nvpair' as value is also ok, or something in between. But it must be a reliable type and not changing depending on the content of the cib. With SAPHanaSR ScaleOut and with clusters having a long history we will get complex cibadmin structures for our checks, so the resulting data structure of the gatherer has to be reliable.

How do I need to change the argument for the gatherer to get the expected result to use in the expression of the 'expectations:' section of a check.

[angelabriel]

fixed in a new version of the gatherer, thanks.