From 694f85356540bbeb738904f840aa382a1ebe65ab Mon Sep 17 00:00:00 2001
From: Xabier Arbulu Insausti <arbulu89@gmail.com>
Date: Thu, 17 Oct 2024 11:48:25 +0200
Subject: [PATCH] Unwip tested checks (#21)

* Set note on checks that cannot be used with majority maker

* Unwip checks after testing and updating them
---
 checks/{3A59DC.yaml.wip => 3A59DC.yaml} | 2 ++
 checks/{3A9890.yaml.wip => 3A9890.yaml} | 2 ++
 checks/{3AA381.yaml.wip => 3AA381.yaml} | 2 ++
 checks/{3AD734.yaml.wip => 3AD734.yaml} | 2 ++
 checks/{A1244C.yaml.wip => A1244C.yaml} | 0
 checks/{ABA3CA.yaml.wip => ABA3CA.yaml} | 2 ++
 checks/{B3DA7E.yaml.wip => B3DA7E.yaml} | 0
 7 files changed, 10 insertions(+)
 rename checks/{3A59DC.yaml.wip => 3A59DC.yaml} (96%)
 rename checks/{3A9890.yaml.wip => 3A9890.yaml} (94%)
 rename checks/{3AA381.yaml.wip => 3AA381.yaml} (95%)
 rename checks/{3AD734.yaml.wip => 3AD734.yaml} (96%)
 rename checks/{A1244C.yaml.wip => A1244C.yaml} (100%)
 rename checks/{ABA3CA.yaml.wip => ABA3CA.yaml} (95%)
 rename checks/{B3DA7E.yaml.wip => B3DA7E.yaml} (100%)

diff --git a/checks/3A59DC.yaml.wip b/checks/3A59DC.yaml
similarity index 96%
rename from checks/3A59DC.yaml.wip
rename to checks/3A59DC.yaml
index 83e5191..e382848 100644
--- a/checks/3A59DC.yaml.wip
+++ b/checks/3A59DC.yaml
@@ -8,6 +8,8 @@ remediation: |
   ## Abstract
   The enabled Solution is **not** the recommended one.
 
+  Note: This check cannot be used on clusters with majority maker.
+
   ## Remediation
   Enable the recommended Solution with `saptune solution change <SOLUTION>`.
   If you running an individual configuration, please create a custom solution starting with the name of the recommended solution, followed by an individual text separated by  **_**  and enable it.
diff --git a/checks/3A9890.yaml.wip b/checks/3A9890.yaml
similarity index 94%
rename from checks/3A9890.yaml.wip
rename to checks/3A9890.yaml
index 38c8722..f73296d 100644
--- a/checks/3A9890.yaml.wip
+++ b/checks/3A9890.yaml
@@ -9,6 +9,8 @@ remediation: |
   The override values must be identical on all nodes but they are different currently.
   This means some/all parameter values from the existing override files differ or an override file is missing on at least one node in the cluster.
 
+  Note: This check cannot be used on clusters with majority maker.
+
   ## Remediation
   Run  `saptune note verify`  on all nodes and compare the overrides.
   If there are differences please fix the related override file.
diff --git a/checks/3AA381.yaml.wip b/checks/3AA381.yaml
similarity index 95%
rename from checks/3AA381.yaml.wip
rename to checks/3AA381.yaml
index 514012f..1253a19 100644
--- a/checks/3AA381.yaml.wip
+++ b/checks/3AA381.yaml
@@ -9,6 +9,8 @@ remediation: |
   But the version of the installed saptune package differs on the cluster nodes.
   Also make sure, that "SAPTUNE_VERSION" in /etc/sysconfig/saptune has identical values on all nodes.
 
+  Note: This check cannot be used on clusters with majority maker.
+
   ## Remediation
   Update the saptune package to get the same version on all cluster nodes
   `zypper update saptune`
diff --git a/checks/3AD734.yaml.wip b/checks/3AD734.yaml
similarity index 96%
rename from checks/3AD734.yaml.wip
rename to checks/3AD734.yaml
index 44b23ba..65336cc 100644
--- a/checks/3AD734.yaml.wip
+++ b/checks/3AD734.yaml
@@ -8,6 +8,8 @@ remediation: |
   ## Abstract
   The same Solution and Notes must be enabled and applied on all cluster nodes. This is the base of having the same configuration even it does not guarantees identical tuning (e.g. staging is used or active diverging overwrites)!
 
+  Note: This check cannot be used on clusters with majority maker.
+
   ## Remediation
   Enable and apply the same Solution and/or Notes on all nodes with the appropriate saptune commands.
   This task includes **reverting** and **applying** Notes or the Solution.
diff --git a/checks/A1244C.yaml.wip b/checks/A1244C.yaml
similarity index 100%
rename from checks/A1244C.yaml.wip
rename to checks/A1244C.yaml
diff --git a/checks/ABA3CA.yaml.wip b/checks/ABA3CA.yaml
similarity index 95%
rename from checks/ABA3CA.yaml.wip
rename to checks/ABA3CA.yaml
index 6efdb12..6d3442d 100644
--- a/checks/ABA3CA.yaml.wip
+++ b/checks/ABA3CA.yaml
@@ -7,6 +7,8 @@ remediation: |
   ## Abstract
   SAP Host Agent should be running on all cluster nodes
 
+  Note: This check cannot be used on clusters with majority maker.
+
   ## Remediation
   Install and start SAP Host Agent on all nodes.
 
diff --git a/checks/B3DA7E.yaml.wip b/checks/B3DA7E.yaml
similarity index 100%
rename from checks/B3DA7E.yaml.wip
rename to checks/B3DA7E.yaml