Docker image building for arm64 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDimonaco
force-pushed
the
docker_image_build_arm
branch
from
5aa1799 to
df8e183
Compare
arbulu89
approved these changes
Jun 11, 2024
.github/workflows/ci.yaml
Outdated
| @@ -26,7 +26,6 @@ jobs: | |||
| build-and-push-container-images: | |||
| name: Build and push container images | |||
| runs-on: ubuntu-22.04 | |||
| if: github.event_name == 'release' || (github.event_name == 'push' && github.ref_name == 'main') | |||
There was a problem hiding this comment.
I guess you will put back this line when you finish testing, right?
CDimonaco
force-pushed
the
docker_image_build_arm
branch
from
df8e183 to
4584e46
Compare
CDimonaco
force-pushed
the
docker_image_build_arm
branch
from
4584e46 to
75a9f56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr enables building arm64 docker images.