fix: Retry GET against 502, 503 and 504 responses #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @yuokada, @ybiquitous maintainers. |
exoego
reviewed
Nov 9, 2024
lib/trino/client/statement_client.rb
Outdated
| @@ -208,7 +208,8 @@ def faraday_get_with_retry(uri, &block) | |||
| return response | |||
| end | |||
|
|
|||
| if response.status != 503 # retry only if 503 Service Unavailable | |||
| # retry if 502, 503, 504 according to the trino protocol | |||
| if response.status == 502 || response.status == 503 || response.status == 504 | |||
There was a problem hiding this comment.
Suggested change
| if response.status == 502 || response.status == 503 || response.status == 504 | |
| unless [502, 503, 504].include?(response.status) |
There was a problem hiding this comment.
Hi, @exoego Thanks for the review.
Turns out I had modified the error handling code to do the opposite, thanks for letting me know.
I have applied your review comment code.
exoego
changed the title
|
Close #128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Retry GET against 502, 504 responses.
Overview
According to the trino client protocol, it should also retry for 502 and 504. (#128)
Checklist