fix: usage of node12 which is deprecated
#521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamirmahal
commented
Nov 15, 2024
| runs: | ||
| using: composite | ||
| steps: | ||
| - uses: actions/setup-node@v2 | ||
| - uses: actions/setup-node@v4 |
There was a problem hiding this comment.
v4 is the latest major version of actions/setup-node at the time of this writing.
|
@hamirmahal why actions did not start in this PR?
|
|
I'm not sure, but all checks passed on my fork.
|
|
Could you update branch and push again. Maybe this problem will be fixed then |
hamirmahal
force-pushed
the
fix/usage-of-node12-which-is-deprecated
branch
from
7559214 to
048cea9
Compare
|
Okay, I just did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #520.
Problem
tests.ymluses node12 which is deprecated.How this change fixes it
This updates a dependency 2 layers deep that
uses node12 which is deprecated.