Missing FitsImage fixes

[tmillenaar]

Hey guys,

I was trying to read fits images using the pyse accessors, but ran into an error while the fits accessor from tkp worked fine. I looked into it and found that the version in pyse is from 7 years ago and is missing some fixes.

The problem I ran into is that I encounter the following line:

pyse/sourcefinder/accessors/fitsimage.py

Line 125 in 43124dc

freq_eff = header['RESTFRQ']

but don't have 'RESTFRQ' in the header, hence a KeyError is raised.

It looks like this was addressed in the following tkp commit:
transientskp/tkp@ae5aa59

I imagine the simplest way to address this is by cargo-culting fits_image.py from tkp:
https://github.com/transientskp/tkp/blob/8a19cd23c7141c66c1ee8e42295957bbcf809531/tkp/accessors/fitsimage.py

@suvayu Shall I make a PR with the copied fits_image.py or would you prefer to tackle this yourself?

Cheers,
Timo

[suvayu]

Hey Timo, Interesting find. Please feel free to open a PR. I'm now wondering if there are other similar backports necessary. If so, how can we find them? -- Suvayu Open source is the future. It sets us free.

…

On Tue, 6 Aug, 2024, 11:42 Timo Millenaar, ***@***.***> wrote: Hey guys, I was trying to read fits images using the pyse accessors, but ran into an error while the fits accessor from tkp worked fine. I looked into it and found that the version in pyse is from 7 years ago and is missing some fixes. The problem I ran into is that I encounter the following line: https://github.com/transientskp/pyse/blob/43124dc7463f3b841d744119e630fd5fcc42ba30/sourcefinder/accessors/fitsimage.py#L125 but don't have 'RESTFRQ' in the header, hence a KeyError is raised. It looks like this was addressed in the following tkp commit: ***@***.*** <transientskp/tkp@ae5aa59> I imagine the simplest way to address this is by cargo-culting fits_image.py from tkp: https://github.com/transientskp/tkp/blob/8a19cd23c7141c66c1ee8e42295957bbcf809531/tkp/accessors/fitsimage.py @suvayu <https://github.com/suvayu> Shall I make a PR with the copied fits_image.py or would you prefer to tackle this yourself? Cheers, Timo — Reply to this email directly, view it on GitHub <#62>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABYBJFG6MK2NXRMKYY3VTLZQCK63AVCNFSM6AAAAABMB6JWMSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2TANBTGA3DMOA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[tmillenaar]

I'll manually check the other accessors as well

[tmillenaar]

I went through the diffs of the files. It looks like most differences were related to

• IOError vs OSError
• logger.warn vs logger.warning
• six metaclass vs buildin metaclass
• formatting

I tried to stay away form the formatting changes, i.e. leave it as much as-is in pyse at the moment.

MR: #63

[suvayu]

Thanks, the implementation of these data accessors are a bit over-engineered, e.g. the use of metaclasses. It should be simplified (see: #53).