Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the ObjectContainer class be removed? #56

Open
HannoSpreeuw opened this issue Jul 17, 2024 · 5 comments
Open

Can the ObjectContainer class be removed? #56

HannoSpreeuw opened this issue Jul 17, 2024 · 5 comments
Assignees

Comments

@HannoSpreeuw
Copy link
Collaborator

@suvayu noticed that the ObjectContainer class has little more than a closest_to method which raises the question if this class could be removed.

I will try to find out what breaks in PySE and in TraP if we remove it.

@HannoSpreeuw HannoSpreeuw self-assigned this Jul 17, 2024
@HannoSpreeuw
Copy link
Collaborator Author

I investigated TraP wrt the ObjectContainer class. It can be removed there and will be after this PR is merged.

@HannoSpreeuw
Copy link
Collaborator Author

The only two problems remaining are lines 56 and 92 in test_L15_12h_const.py.

There the closest_to method is tested.

But if we remove the closest_to method, we do not need to test it, i.e. we can remove those two unit tests, I would think.

@HannoSpreeuw
Copy link
Collaborator Author

An easy solution may be to add the closest_to method to the L15_12hConstObs class and to the L15_12hConstCor class.

Downside is that you have to add the same method twice.

@suvayu suvayu closed this as completed in 4691a43 Oct 29, 2024
@HannoSpreeuw
Copy link
Collaborator Author

Why is this closed?
I mean, the ObjectContainer class is still there.

@suvayu
Copy link
Collaborator

suvayu commented Oct 30, 2024

Not sure, I think it got closed automatically, or maybe I mistook it for another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants