Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for modifying Polygons #12

Open
acannistra opened this issue May 13, 2021 · 0 comments
Open

Add support for modifying Polygons #12

acannistra opened this issue May 13, 2021 · 0 comments

Comments

@acannistra
Copy link
Contributor

#11 introduced support for <create> nodes in Polygons, but did not implement modifying Polygons when they intersected with another feature (e.g. https://github.com/trailbehind/changegen/pull/11/files#diff-0f0589840ba0db708b762b8eeea2d8b2b44258b433147acc90ab09b013292fd3R690-R702)

We might want to allow for the creation of <modify> nodes whenever a feature intersects with a Polygon. This is complicated when the polygon is actually a relation, because we don't have the ID of the Way that represents the Exterior of the multipolygon (or polygon w/ holes).

In these cases we need a way to determine the outer ring of the Polygon so we can modify it. This is complicated and requires a design, so we're leaving it as an open issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant