Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin lifecycle #42

Open
mloiseleur opened this issue Jul 25, 2022 · 4 comments
Open

Plugin lifecycle #42

mloiseleur opened this issue Jul 25, 2022 · 4 comments

Comments

@mloiseleur
Copy link
Contributor

mloiseleur commented Jul 25, 2022

Current Behavior

One can
a) change gh account name : from tommoulard to tomMoulard, for instance
b) move or fork the (same) plugin to another account: from my_repo to my_company, for instance

When it happens:

  1. plugin-service fails to download (valid) plugin with the old naming. For instance, tommoulard/fail2ban plugin is still valid up to v6.0.2. You can check it here.
  2. The change is not visible in plugin-catalog UI
  3. It generates tons of (false) error log.

Expected Behavior

When one rename his gh account, move or depreciate his plugin, this should be handled gracefully, on both backend & frontend sides. Both plugin developer or TraefikLabs should be able to handle this use case.

⚠️ GitHub accounts are case in-sensitive but Go Modules are case sensitive.

@mloiseleur mloiseleur changed the title Repo address can change Repo main address can change Jul 25, 2022
@ldez
Copy link
Contributor

ldez commented Jul 25, 2022

The problem with the repo of tom is known, it's not an issue with our service but with the user.

The plugin service doesn't work as GitHub but as a Go proxy: the module names are case sensitive due to several reasons related to Go.

@ldez
Copy link
Contributor

ldez commented Jul 25, 2022

The problem behind the names has been fixed in the service, only the tom's repo is still a problem for historical reasons.

@ldez
Copy link
Contributor

ldez commented Jul 25, 2022

Also, the problem is not related to the repo name but to the module name and plugin name.

https://github.com/traefik/plugindemo/blob/173560df05cb3e43cefc7dd4b592eef74188a19b/.traefik.yml#L5

@mloiseleur mloiseleur changed the title Repo main address can change Repo main import address can change Jul 25, 2022
@mloiseleur mloiseleur changed the title Repo main import address can change Plugin import address can change Jul 25, 2022
@mloiseleur
Copy link
Contributor Author

mloiseleur commented Jul 25, 2022

Also, the problem is not related to the repo name but to the module name and plugin name.

https://github.com/traefik/plugindemo/blob/173560df05cb3e43cefc7dd4b592eef74188a19b/.traefik.yml#L5

Yes, thanks. I updated the issue accordingly.

@mloiseleur mloiseleur changed the title Plugin import address can change Plugin lifecycle Jul 25, 2022
This was referenced Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants