Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why do we need the charting library folder both in public and in src? #397

Open
1 task
orelhindi-abra opened this issue Sep 30, 2024 · 1 comment
Open
1 task

Comments

@orelhindi-abra
Copy link

orelhindi-abra commented Sep 30, 2024

Checklist

  • This issue is NOT related to the charting library itself

Describe the bug
According to the documentation, the charting library folder needs to be placed in both the src and public directories. I would like to understand the reasoning behind this requirement.
Moreover, the datafeeds library which we need to use like so in the index.html file:
<script src="./datafeeds/udf/dist/bundle.js"></script>
is there way to use datafeed without using it directly in the html file? because if its not provided we get the following error:
react-dom_client.js?v=54d56a3b:9127 Uncaught TypeError: Cannot read properties of undefined (reading 'UDFCompatibleDatafeed')

I'm currently trying to build a package from this project and need guidance on the best approach for handling this setup during the build process. Is there a recommended way to manage the charting library when packaging the project to avoid duplication in both folders?

Thank you for your help!

A clear and concise description of what the bug is.

Expected behavior

To only use the charting library folder once.

@orelhindi-abra
Copy link
Author

any?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant