Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LR Scheduler init should return Result<Scheduler, ...> instead of panicking #2510

Closed
laggui opened this issue Nov 18, 2024 · 1 comment · Fixed by #2527
Closed

LR Scheduler init should return Result<Scheduler, ...> instead of panicking #2510

laggui opened this issue Nov 18, 2024 · 1 comment · Fixed by #2527
Labels
good first issue Good for newcomers

Comments

@laggui
Copy link
Member

laggui commented Nov 18, 2024

As discussed in #2423.

Invalid initialization should not panic. We should refactor all schedulers to follow the same pattern (especially since warnings won't show up with the built-in logger + learner).
@laggui laggui added the good first issue Good for newcomers label Nov 18, 2024
@towerpark
Copy link
Contributor

I will work on it while the details are still fresh in my mind.
By the way, I will create another issue for the logging problem after this one is done.

@towerpark towerpark mentioned this issue Nov 23, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make .init() method of LR schedulers return Result towerpark/burn
2 participants
@laggui @towerpark