You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
tensor::module::conv2d() should check if dilation is greater than 0.
I haven't checked, but conv1d and conv3d also should have that check included.
Feature motivation
Mathematically convolution with dilation (0,0) doesn't really make sense. The implementation in backends can handle dilation (0,0) without error, but the output is nonsensical.
(Optional) Suggest a Solution
Presumably a simple if () {panic!()} will work.
The text was updated successfully, but these errors were encountered:
Feature description
tensor::module::conv2d()
should check ifdilation
is greater than 0.I haven't checked, but
conv1d
andconv3d
also should have that check included.Feature motivation
Mathematically convolution with dilation (0,0) doesn't really make sense. The implementation in backends can handle dilation (0,0) without error, but the output is nonsensical.
(Optional) Suggest a Solution
Presumably a simple
if () {panic!()}
will work.The text was updated successfully, but these errors were encountered: