Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conv2d should check if dilation > 0 #2481

Open
Quba1 opened this issue Nov 12, 2024 · 0 comments
Open

conv2d should check if dilation > 0 #2481

Quba1 opened this issue Nov 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Quba1
Copy link
Contributor

Quba1 commented Nov 12, 2024

Feature description

tensor::module::conv2d() should check if dilation is greater than 0.

I haven't checked, but conv1d and conv3d also should have that check included.

Feature motivation

Mathematically convolution with dilation (0,0) doesn't really make sense. The implementation in backends can handle dilation (0,0) without error, but the output is nonsensical.

(Optional) Suggest a Solution

Presumably a simple if () {panic!()} will work.

@laggui laggui added the bug Something isn't working label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants