Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create minor mode for julia-repl #30

Open
non-Jedi opened this issue Jul 6, 2018 · 3 comments
Open

Create minor mode for julia-repl #30

non-Jedi opened this issue Jul 6, 2018 · 3 comments

Comments

@non-Jedi
Copy link

non-Jedi commented Jul 6, 2018

If a buffer gets created by e.g. julia-repl-send-line, that buffer doesn't have the julia-repl-mode minor mode defined here. Is that an oversight, or am I misunderstanding how emacs minor modes should work (very possible; I'm still quite emacs noobish)?

@non-Jedi non-Jedi closed this as completed Jul 6, 2018
@non-Jedi non-Jedi reopened this Jul 6, 2018
@non-Jedi non-Jedi changed the title Define minor mode for julia-repl buffer julia-repl-mode minor mode doesn't get enabled by standard entry points Jul 6, 2018
@non-Jedi
Copy link
Author

non-Jedi commented Jul 6, 2018

@tpapp
Copy link
Owner

tpapp commented Jul 6, 2018

The julia-repl-mode is a minor mode for Julia source code files (.jl). julia-repl.el does not define a minor mode for the inferior buffer.

Would one be useful for you?

@non-Jedi
Copy link
Author

non-Jedi commented Jul 6, 2018

Ah. I see. Yes it would be, but thanks to julia-repl-hooks I can at least work around it.

Spacemacs keybinding config system works per-mode rather than per-buffer.

EDIT: turning the julia-repl function into a minor mode doesn't look like it'd be all that difficult. I may take a shot at a PR for such if I get time in the next few weeks.

@non-Jedi non-Jedi changed the title julia-repl-mode minor mode doesn't get enabled by standard entry points Create minor mode for julia-repl Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants