Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SecRandomCopyBytes #43

Merged
merged 7 commits into from
Oct 3, 2023
Merged

Use SecRandomCopyBytes #43

merged 7 commits into from
Oct 3, 2023

Conversation

05nelsonm
Copy link
Collaborator

@05nelsonm 05nelsonm commented Oct 2, 2023 •
edited
Loading

This PR is a fix to #39 , which will remain open until things go live upstream and can be pulled into this codebase.

The fix allows enabling of tvOS and watchOS targets.

It modifies the SQLite3MultipleCiphers amalgamations to use SecRandomCopyBytes for darwin targets, in line with the fix expressed HERE.

05nelsonm
05nelsonm commented Oct 2, 2023
View reviewed changes
Copy link
Collaborator Author

@05nelsonm 05nelsonm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@05nelsonm
Copy link
Collaborator Author

05nelsonm commented Oct 2, 2023 •
edited
Loading 

> Task :library:driver:iosSimulatorArm64Test SKIPPED
e: /Applications/Xcode_14.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld invocation reported errors
> Task :library:driver-test:linkDebugTestIosSimulatorArm64 FAILED
The /Applications/Xcode_14.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld command returned non-zero exit code: 1.
output:
ld: warning: object file (/private/var/folders/3s/vfzpb5r51gs6y328rmlgzm7c0000gn/T/konan_temp130378032671[85](https://github.com/toxicity-io/sqlite-mc/actions/runs/6381376828/job/17317720607?pr=43#step:9:85)517018/result.o) was built for newer iOS Simulator version (14.0) than being linked (9.0)
Undefined symbols for architecture arm64:
  "_SecRandomCopyBytes", referenced from:
      _entropy in result.o
  "_kSecRandomDefault", referenced from:
      _entropy in result.o
ld: symbol(s) not found for architecture arm64
> Task :library:driver:iosX64Sqlite3mc
FAILURE: Build failed with an exception.

🤔

@05nelsonm 05nelsonm force-pushed the issue/39-secrandomcopybytes branch 4 times, most recently from bd5d3c5 to 95943af Compare October 2, 2023 14:55
@05nelsonm 05nelsonm force-pushed the issue/39-secrandomcopybytes branch from 95943af to 8611b1c Compare October 2, 2023 15:32
05nelsonm
05nelsonm commented Oct 2, 2023
View reviewed changes
Copy link
Collaborator Author

@05nelsonm 05nelsonm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@05nelsonm 05nelsonm force-pushed the issue/39-secrandomcopybytes branch from 0b0121a to 77eb39c Compare October 2, 2023 18:50
05nelsonm
05nelsonm commented Oct 2, 2023
View reviewed changes
Copy link
Collaborator Author

@05nelsonm 05nelsonm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@05nelsonm 05nelsonm force-pushed the issue/39-secrandomcopybytes branch 3 times, most recently from c1058f6 to fe3250e Compare October 3, 2023 01:28
@05nelsonm 05nelsonm force-pushed the issue/39-secrandomcopybytes branch from fe3250e to c6b917e Compare October 3, 2023 03:16
@05nelsonm 05nelsonm merged commit 06dc753 into master Oct 3, 2023
5 of 6 checks passed
@05nelsonm 05nelsonm deleted the issue/39-secrandomcopybytes branch October 3, 2023 04:43
@05nelsonm 05nelsonm mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@05nelsonm