Backport endpoint consistency and CI changes to v0.1 #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changed-files action fails when pushing a tag: Error: Similar commit hashes detected: previous sha: a9cf47f is equivalent to the current sha: a9cf47f. Error: Please verify that both commits are valid, and increase the fetch_depth to a number higher than 50. Error: Similar commit hashes detected. (cherry picked from commit 440ca88)
Using main would introduce unwanted changes.
(cherry picked from commit a787a32)
…rom the REST response for TTS. (cherry picked from commit c6d7d17)
…play and TTS language to other endpoints (cherry picked from commit dc1d55d)
…text color, standardize feedback language (cherry picked from commit f347102)
…to align with REST and OpenHAB (cherry picked from commit e24c053)
Hiding labels after calling the endpoint could result in them being hidden after the endpoint unhid them. This currently seems to happen for both the openHAB and the REST endpoint. Adding some logging confirms the label is hid in the audio code just a few milliseconds after unhiding in the endpoint code. We don't see this with Home Assistant as we're using a recent Home Assistant version where the endpoint code sets up a WebSocket. The additional JSON constructing and parsing in the Home Assistant WebSocket code causes enough delay to not see the issue there. (cherry picked from commit c18aa98)
stintel
force-pushed
the
backport/0.1
branch
from
16a7068
to
fa22cce
Compare
stintel
changed the title
(cherry picked from commit 06e27f4)
(cherry picked from commit 711c258)
We're using tags like will-be-deleted-something for test tags, to verify things work as expected before tagging an actual release tag. Mark a release as pre-release if the tag contains delete. (cherry picked from commit 4a83be7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And some CI changes required to make sure we build using the right container.