Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdkconfig improvements #258

Merged
merged 5 commits into from
Sep 11, 2023
Merged

sdkconfig improvements #258

merged 5 commits into from
Sep 11, 2023

Conversation

stintel
Copy link
Collaborator

@stintel stintel commented Sep 5, 2023

  • use sdkconfig.defaults
  • disable DHCP/TLS server support
  • disable TLS < 1.2
  • disable Wi-Fi SoftAP support

@kristiankielhofner
Copy link
Contributor

kristiankielhofner commented Sep 11, 2023 •
edited by stintel
Loading

I'm seeing a crash and bootloop:

I (11:58:05.580) WILLOW/MAIN: Startup complete! Version: 0.1.0-rc.1-12-g4de88e9. Waiting for wake word.
E (24416) task_wdt: Task watchdog got triggered. The following tasks did not reset the watchdog in time:
E (24416) task_wdt:  - IDLE (CPU 1)
E (24416) task_wdt: Tasks currently running:
E (24416) task_wdt: CPU 0: IDLE
E (24416) task_wdt: CPU 1: feed_task
E (24416) task_wdt: Aborting.

abort() was called at PC 0x420ab6d8 on core 0


Backtrace: 0x4037a1be:0x3fca01c0 0x40383fed:0x3fca01e0 0x4038c0c6:0x3fca0200 0x420ab6d8:0x3fca0270 0x4037b241:0x3fca02a0 0x4213dc2b:0x3fcb3550 0x420048a9:0x3fcb3570 0x403853db:0x3fcb3590

@stintel
Copy link
Collaborator Author

stintel commented Sep 11, 2023 •
edited
Loading

This very much looks like what I saw when I bumped ESP-ADF to 2.6. What is probably happening is that you updated your build container, so you're now building with ESP-ADF 2.6 without the changes required in Willow (985e8ec).

I will create a new PR to bump ESP-SR and ESP-ADF separately to solve this. This will also work around the CI issue we're seeing for 922de25.

Update: #260 created. Will rebase both feature/sdkconfig and feature/multiwake after it's merged.

@stintel
sdkconfig: use sdkconfig.defaults
c03427d 
Use sdkconfig.defaults instead of maintaining a full sdkconfig in git.
The sdkconfig resulting from running `./utils.sh install` with this
commit should be the same as before this commit.

We can re-evaluate some of these values at a later stage, but we should
first start with identical sdkconfig. This will make bisecting easier.
If we were to change sdkconfig values in this commit, reverting the
commit would completely revert the use of sdkconfig.defaults.

Fixes: #21
@stintel
sdkconfig: disable DHCP server
f3dd33f
@stintel
sdkconfig: disable TLS server support
c5c2f93
@stintel
sdkconfig: disable TLS < 1.2
9a53df2
@stintel
sdkconfig: disable Wi-Fi SoftAP support
24e0253
@kristiankielhofner kristiankielhofner merged commit 11e8d21 into main Sep 11, 2023
12 checks passed
@kristiankielhofner kristiankielhofner deleted the feature/sdkconfig_defaults branch September 11, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristiankielhofner kristiankielhofner kristiankielhofner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stintel @kristiankielhofner