overridding path variable in pagination.files

[ninjasort]

I'm using this with metalsmith-pagination and it's somehow overriding the post metadata and removing the path variable provided by metalsmith-pagination.

[maiertech]

I'm having a similar issue when using metalsmith-collections. I traced it down to this line:

metalsmith-tags/lib/index.js

Line 195 in 99837b4

metalsmith.metadata(metadata);

It does a deep clone when setting Metalsmith's _metadata and this causes objects in files and collections to be different. See metalsmith/metalsmith#247.

I guess a quick fix is removing

metalsmith-tags/lib/index.js

Lines 193 to 196 in 99837b4

	// update metadata
	if (!opts.skipMetadata) {
	metalsmith.metadata(metadata);
	}

because metadata is already the real (non-cloned) Metalsmith metadata (set here:

metalsmith-tags/lib/index.js

Line 126 in 99837b4

var metadata = metalsmith.metadata();

).

Anyone any thoughts?

[Ajedi32]

Isn't this basically a dup of #21?

[maiertech]

Yes