Use typing.overload to improve type hints of pypika.terms
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henadzit
reviewed
Dec 3, 2024
| @@ -66,10 +67,31 @@ def tables_(self) -> set["Table"]: | |||
| def fields_(self) -> set["Field"]: | |||
| return set(self.find_(Field)) | |||
|
|
|||
| if TYPE_CHECKING: # pragma: nocoverage | |||
|
|
|||
| @typing.overload | |||
There was a problem hiding this comment.
It feels like we are masking the bad typing problem instead of solving it.
There was a problem hiding this comment.
After there typing lines added, there are about 40 markers of type:ignore removed!
| def wrap_constant(val: tuple, wrapper_cls: Type[Term] | None = None) -> "Tuple": ... | ||
| @typing.overload | ||
| @staticmethod | ||
| def wrap_constant(val: Any, wrapper_cls: None = None) -> "ValueWrapper": ... |
There was a problem hiding this comment.
This one is not like the others.
There was a problem hiding this comment.
I really don't like such two functions(wrap_constant/wrap_json), they looks strange. It will be very great if you can refactor them...
waketzheng
force-pushed
the
type-hints-terms
branch
from
cfc81e8 to
0b72eae
Compare
|
Hey, please have a look at my PR that removes these warnings without adding overloading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not change any logic, only type hints improve