Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in 2_supervised/1_data.lua when size='small' #24

Open
almson opened this issue Jul 2, 2015 · 0 comments
Open

bug in 2_supervised/1_data.lua when size='small' #24

almson opened this issue Jul 2, 2015 · 0 comments

Comments

@almson
Copy link

almson commented Jul 2, 2015

The YUV conversion is done only on the first 10000 elements of trainData.data, but the global normalization is done across all elements (including those which are still RGB and which have a different mean/variance). Fix is to slice the training/test data when doing global normalization, and again when "verifying statistics."

As an aside, why do the comments state "luminance is locally normalized and color globally," when in fact local and global normalization is applied to all channels?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant