We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I came across a package that was updating its git hooks with a post install script:
"postinstall": "npx simple-git-hooks",
When that package was installed as a dependency of another package, it installed the hooks in the parent package.
The text was updated successfully, but these errors were encountered:
Hi, thanks for the report. Gonna try to catch and fix this in spare time
Sorry, something went wrong.
same problem. can resolved it now?
Okay, there are two problems here:
If you do not use simple-git-hooks you are going to get something like this:
simple-git-hooks
npm ERR! code 127 npm ERR! path /home/.../workspace/test/node_modules/json-editor-vue npm ERR! command failed npm ERR! command sh -c simple-git-hooks npm ERR! sh: line 1: simple-git-hooks: command not found
Taken from cloydlau/json-editor-vue#73
I will not be able to fix this, since simple-git-hooks is not even executed here :(
If you have simple-git-hooks then this package will trigger install of the hooks. Will add an additional check for that case
l generally advise agains calling simple-git-hooks as a postinstall script in your own package. It should be removed upon publishing to npm.
npm
Added a note about that in `README.md
No branches or pull requests
I came across a package that was updating its git hooks with a post install script:
When that package was installed as a dependency of another package, it installed the hooks in the parent package.
The text was updated successfully, but these errors were encountered: