copy: add support for non-octal mode setting #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
changed the title
tonistiigi
force-pushed
the
tonistiigi/mode-non-octal
branch
2 times, most recently
from
f86e52c to
c34b113
Compare
tonistiigi
force-pushed
the
tonistiigi/mode-non-octal
branch
from
c34b113 to
8f1d41d
Compare
crazy-max
approved these changes
Oct 1, 2024
bench/go.mod
Outdated
| go 1.20 | ||
| go 1.21 | ||
|
|
||
| toolchain go1.23.1 |
There was a problem hiding this comment.
toolchain strikes again 😅
Comment on lines
+40
to
+42
| if c.modeSet != nil { | ||
| return errors.Errorf("non-octal mode not supported on windows") | ||
| } |
There was a problem hiding this comment.
Don't think a module exists for this but I think on Windows we could use golang.org/x/sys/windows to set corresponding Windows ACL permissions if we want that in the future (cc @gabriel-samfira)
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
tonistiigi/mode-non-octal
branch
from
8f1d41d to
3a8c87e
Compare
crazy-max
approved these changes
Oct 1, 2024
thaJeztah
reviewed
Oct 1, 2024
| @@ -9,6 +9,7 @@ require ( | |||
| github.com/opencontainers/go-digest v1.0.0 | |||
| github.com/pkg/errors v0.9.1 | |||
| github.com/stretchr/testify v1.8.4 | |||
| github.com/tonistiigi/dchapes-mode v0.0.0-20241001053921-ca0759fec205 | |||
There was a problem hiding this comment.
I see the original repository has a number of tagged versions already; should those be inherited? https://hg.sr.ht/~dchapes/mode/tags
There was a problem hiding this comment.
This is not the same source. I don't plan to make my own releases in the fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prerequisite for moby/buildkit#1951