copy: fix to respect most significant octet of given permission in copyFileInfo #168
+57
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kotaro Inoue <[email protected]>
musaprg
changed the title
musaprg
changed the title
musaprg
force-pushed
the
fix-to-respect-special-bits
branch
from
d4f5183 to
e4b0bef
Compare
Signed-off-by: Kotaro Inoue <[email protected]>
musaprg
force-pushed
the
fix-to-respect-special-bits
branch
from
e4b0bef to
0db3c1f
Compare
musaprg
changed the title
Signed-off-by: Kotaro Inoue <[email protected]>
|
It seems CI failed due to another issue on freebsd job, which might not be related to this PR. I suppose we need to wait for this patch being merged into master. #172 |
tonistiigi
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
(*copier).copyFileInfo()to respect special bits specified in the copier struct. It causes the BuildKit issue whereCOPY --chmoddoesn't respect the most significant octet of the Unix Permission.This behavior might be intended because setting setuid/setgid to an executable file was known as an anti-pattern in terms of security. However, this command should not ignore them implicitly if the user understands its drawbacks and desires to set them.
Additional Information
It seems Go's
os.FileModehas its internal representation of special bits. We need to convert special bits to internal representation to set them properly.