Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copyFileContent broken on zfs (in some cases) #96

Closed
codyps opened this issue Jan 8, 2021 · 1 comment · Fixed by #98
Closed

copyFileContent broken on zfs (in some cases) #96

codyps opened this issue Jan 8, 2021 · 1 comment · Fixed by #98

Comments

@codyps
Copy link

codyps commented Jan 8, 2021

See moby/moby#41866

Basically, need to add EINVAL on this line:

if (err != unix.ENOSYS && err != unix.EXDEV && err != unix.EPERM) || !first {

Also worth considering if any error should cause the fallback.

I haven't isolated the kernel version/zfs version that causes the issue. My kernel & zfs version are posted in the moby ticket linked above.

There's also an identical issue in containerd/continuity: containerd/continuity#176

@tonistiigi
Copy link
Owner

@jmesmon Send the patches to the affected repos. Match the behavior/argumentation to https://github.com/golang/go/blob/5f646f0a984d43a2e9e99a1338145a862fef425e/src/internal/poll/copy_file_range_linux.go#L90-L112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants