Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error boundaries #24

Open
tomwayson opened this issue Jan 29, 2019 · 0 comments
Open

add error boundaries #24

tomwayson opened this issue Jan 29, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@tomwayson
Copy link
Owner

https://reactjs.org/docs/error-boundaries.html

Probably at the top level of each route, and maybe around the nav?

Would be ideal if we could get rid of the catch for fetching items:

.catch(e => {
this.setState({
error: e.message || e,
results: null,
total: 0
});
});

I also wonder what happens if there are JSAPI errors w/in an error boundary. Should test that and maybe explicitly add one around the map component.

@tomwayson tomwayson added the enhancement New feature or request label Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant