Skip to content

Commit

Permalink
Adds patches/20241023-typename. #70
Browse files Browse the repository at this point in the history
  • Loading branch information
tommie committed Oct 23, 2024
1 parent fbf0d11 commit e2cf722
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 0 deletions.
14 changes: 14 additions & 0 deletions .github/workflows/v8build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ jobs:
echo "v8_hash=$latest_v8_hash" >>"$GITHUB_OUTPUT"
- name: Apply Patches
run: |
for f in patches/*.patch; do
echo "Apply $f"
patch -p1 -i "$f"
done
- name: Create include files
run: cd deps && ./build_common.py

Expand Down Expand Up @@ -115,6 +122,13 @@ jobs:
git fetch --depth=1 origin "$latest_v8_hash"
git checkout "$latest_v8_hash"
- name: Apply Patches
run: |
for f in patches/*.patch; do
echo "Apply $f"
patch -p1 -i "$f"
done
- name: Configure CCache
run: |
ccacheDir="$HOME/.ccache"
Expand Down
23 changes: 23 additions & 0 deletions patches/20241023-typename.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
Submodule deps/v8 contains modified content
diff --git a/deps/v8/include/v8-internal.h b/deps/v8/include/v8-internal.h
index a13db2bd74a..77cbf8fc026 100644
--- a/deps/v8/include/v8-internal.h
+++ b/deps/v8/include/v8-internal.h
@@ -1430,7 +1430,7 @@ struct MaybeDefineIteratorConcept {};
template <typename Iterator>
struct MaybeDefineIteratorConcept<
Iterator, std::enable_if_t<kHaveIteratorConcept<Iterator>>> {
- using iterator_concept = Iterator::iterator_concept;
+ using iterator_concept = typename Iterator::iterator_concept;
};
// Otherwise fall back to `std::iterator_traits<Iterator>` if possible.
template <typename Iterator>
@@ -1443,7 +1443,7 @@ struct MaybeDefineIteratorConcept<
// TODO(pkasting): Add this unconditionally after dropping support for old
// libstdc++ versions.
#if __has_include(<ranges>)
- using iterator_concept = std::iterator_traits<Iterator>::iterator_concept;
+ using iterator_concept = typename std::iterator_traits<Iterator>::iterator_concept;
#endif
};

0 comments on commit e2cf722

Please sign in to comment.