Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain Plugin Order As Defined in JSON #567

Open
jvanderen1 opened this issue Aug 13, 2024 · 1 comment
Open

Retain Plugin Order As Defined in JSON #567

jvanderen1 opened this issue Aug 13, 2024 · 1 comment

Comments

@jvanderen1
Copy link
Contributor

I noticed that if you have multiple plugins defined, PGSync will use alphabetical order of the file name(s) instead of the order defined in the schema.json.

Example:

"plugins": [
  "ZSerializer",  # z_serializer.py
  "ASerializer"   # a_serializer.py
]

What's Wrong?

First ASerializer is executed first, followed by ZSerializer. This is because a_serializer.py comes before z_serializer.py.

What Should Happen

The schema.json clearly defined the order to be ZSerializer first, then ASerializer. Therefore, it should respect that order.

@toluaina
Copy link
Owner

This had been resolved in main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants