Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Create automated tests for reset password requests #2727

Closed
StaNov opened this issue Nov 27, 2024 · 3 comments
Closed

Internal: Create automated tests for reset password requests #2727

StaNov opened this issue Nov 27, 2024 · 3 comments
Labels
for-superday Tolgee SuperDay is a step part hiring process when candidate work on real task

Comments

@StaNov
Copy link
Collaborator

StaNov commented Nov 27, 2024

In #2724, limiting reset password requests were implemented without tests.

Add tests covering the code added.

Marking as for-superday since it looks like a good task where no domain knowledge is needed.

@StaNov StaNov added the for-superday Tolgee SuperDay is a step part hiring process when candidate work on real task label Nov 27, 2024
@subchat
Copy link

subchat commented Dec 2, 2024

Hello sir, I can confirm that the reset password requests were implemented properly and Rate Limit is rightfully Implemented.

@JanCizmar
Copy link
Contributor

I believe the @RateLimit annotation is generally tested, so it's probably not necessary to test it specifically for the the password request or login endpoins.

@subchat
Copy link

subchat commented Dec 3, 2024

@JanCizmar , Sir, here it was implemented but in my recent report(as you asked me to report individually in Github) I showed you that other end points for api - like "generate-token" is not rate limited and gives a Jwt token that leads to account takeover and IDOR. Please check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for-superday Tolgee SuperDay is a step part hiring process when candidate work on real task
Projects
None yet
Development

No branches or pull requests

4 participants