Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Merge Silo methods #538

Open
ybekdemir opened this issue Jul 6, 2018 · 0 comments
Open

Refactor Merge Silo methods #538

ybekdemir opened this issue Jul 6, 2018 · 0 comments
Labels
engineering

Comments

@ybekdemir
Copy link

Merge silo and append silo methods currently has more than 300 lines of code. This is to much for two methods. We should separate this methods to smaller functions in order to increase readability and maintainability. Also, we should apply PEP8 to this methods and increase test coverage for them.

Methods to be refactor:

def merge_two_silos(mapping_data, lsid, rsid, msid)
def appendTwoSilos(mapping_data, lsid, rsid, msid):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engineering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ybekdemir