Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Google import process #537

Open
ybekdemir opened this issue Jul 6, 2018 · 0 comments
Open

Refactor Google import process #537

ybekdemir opened this issue Jul 6, 2018 · 0 comments

Comments

@ybekdemir
Copy link

Google import and export methods are very open to create new bugs, code is not readable and not suitable for PEP8. Also, methods include unnecessary codes and logical mistakes. In order to make google import code more readable and maintainable, we should refactor google export methods and increase test coverage for them.

Methods to be refactor for export process :
def import_from_gsheet(request, id):

                              sheet_id=None, partialcomplete=False):```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant