Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate silo views to generic view #535

Open
ybekdemir opened this issue Jul 5, 2018 · 0 comments
Open

Migrate silo views to generic view #535

ybekdemir opened this issue Jul 5, 2018 · 0 comments

Comments

@ybekdemir
Copy link

ybekdemir commented Jul 5, 2018

Current behavior

Currently we are using separated view functions for silo detail, silo edit, list silo and delete silo pages and we have similar permissions check for each other. When we need to update permissions, we have to update each other. Also, it's not readable.

Current view functions.
def list_silos(request):
def edit_silo(request, id):
def silo_detail(request, silo_id):
def list_silos(request):

Expected behavior

We should use generic views for list, detail and silo edit pages. Therefore, we can use same permission class for all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant