Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV imports don't handle different encodings or non-accented characters well #460

Open
sanjuroj opened this issue Mar 29, 2018 · 0 comments

Comments

@sanjuroj
Copy link
Collaborator

Current behavior

CSV imports of files that contain non-ascii characters are not handled well. In some cases a UTF-8 encoded file with accented characters can't be edited. In other cases (e.g. "Comma Separated Values" or windows encoding from Mac version of Excel), the files won't be loaded at all.

Expected behavior

Handle at least UTF-8 ecoded documents well. It would be nice to detect Windows encodings too.

Steps to reproduce the behavior

For UTF-8 encoded file:

  1. Save file from Excel with non-ascii characters using the "CSV UTF-8" format.
  2. Upload to Tola Tables.
  3. Click on a row to edit.
  4. Try to save the changes. A UnicodeEncodeError is thrown with the message "'ascii' codec can't encode character u'\ufeff' in position 6: ordinal not in range(128)"

For other encodings, after the Table selection screen, an InvalidStringData error is thrown with the message "strings in documents must be valid UTF-8: 'test \x87ccented \x8e letters'"

Additional details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant