Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate SiteProfile address for Germany #1145

Open
rafa-munoz opened this issue Sep 10, 2018 · 1 comment
Open

Validate SiteProfile address for Germany #1145

rafa-munoz opened this issue Sep 10, 2018 · 1 comment

Comments

@rafa-munoz
Copy link
Contributor

rafa-munoz commented Sep 10, 2018

Current behavior

At the moment anyone can save any German address with the format that they want. This fact can create inconsistencies:

  • We don't send addresses properly formated to third parties (e.g.: Google Maps).
  • Clients do not know how to store in a proper way addresses and get lost with address line numbers.

Expected behavior

In order to have better control of that, we need to check all fields before saving using the following schema: https://en.wikipedia.org/wiki/Address_(geography)#Germany

  • The postal code always consists of five digits.
  • Building number can be a combination of numbers and letters. E.g.: 16A. It´s also possible that it does not exist, but those are corner cases for Government buildings.
  • There are a few places that have house numbers but no street names.
@rafa-munoz
Copy link
Contributor Author

@jefmoura @glind please check if you agree with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant