Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in the post notify teams channel run #35

Closed
abivolmv opened this issue Jan 25, 2021 · 6 comments
Closed

Error in the post notify teams channel run #35

abivolmv opened this issue Jan 25, 2021 · 6 comments
Assignees

Comments

@abivolmv
Copy link

abivolmv commented Jan 25, 2021

We get this error in the post notify teams channel run:

(node:3227) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'login' of null
    at Object.formatCompactLayout (/home/runner/work/_actions/toko-bifrost/ms-teams-deploy-card/3.1.2/dist/post/index.js:1:236544)
    at Object.formatAndNotify (/home/runner/work/_actions/toko-bifrost/ms-teams-deploy-card/3.1.2/dist/post/index.js:1:37551)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
(node:3227) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:3227) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
runs-on: ubuntu-18.04
    steps:
      - name: Notify Teams channel
        uses: toko-bifrost/[email protected]
        if: always()
        with:
          webhook-uri: ${{ secrets.MSO_TEAMS_WEBHOOK_URI }}
          github-token: ${{ github.token }}
          environment: ${{github.event.inputs.env}}
          show-on-start: false
@abivolmv
Copy link
Author

abivolmv commented Feb 5, 2021

Bump

@abivolmv
Copy link
Author

It seems the author is no longer available:

`by [@${author.login}](${author.html_url})`;

@aldwyn-acn aldwyn-acn self-assigned this Feb 27, 2021
@abivolmv
Copy link
Author

abivolmv commented Mar 5, 2021

@aldwyn-acn do you think you can check it out soon ? ☺️

@aldwyn-acn
Copy link
Contributor

Hey @abivolmv, ah yes, I will. Apologies 🙃

@abivolmv
Copy link
Author

@aldwyn-acn also pls check #34 hate to do this but I really would appreciate these fixes ☺️

@aldwyn-acn
Copy link
Contributor

Hi @abivolmv, the author.login is still in the API. See this sample.

This issue only happens when the committer hasn't set its existing Github account email address in the git config --local user.email (or --global).

See this issue: Request for commits “author”: null and “committer”: null, can’t get user login

By the way, this repo has been inactive for months now I just forked it on my personal Github acct. I will be leaving the team soon and no one is going to maintain it there. So kindly check aldwyn/ms-teams-deploy-card@master for its continued maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants