편집 취소버튼 눌러도 저장 #103
Closed
편집 취소버튼 눌러도 저장 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for todaytheylearned ready! 🔨 Explore the source changes: 183acc2 🔍 Inspect the deploy log: https://app.netlify.com/sites/todaytheylearned/deploys/62160cd36760c100081a43da 😎 Browse the preview: https://deploy-preview-103--todaytheylearned.netlify.app/ |
|
pr은 프로젝트 연결은 안해도 된답니단 |
|
base브랜치 바꿔야해요 ㅠㅠ 지금 main 브랜치에 병합중이어서 제가 develop으로 고쳐놓음.. |
minjj0905
requested changes
Feb 23, 2022
| @@ -107,7 +107,8 @@ const ProfileEdit = () => { | |||
| /> | |||
| </Styled.AvatarFormContainer> | |||
| <Styled.ActionContainer> | |||
| <Styled.BackButton>취소</Styled.BackButton> | |||
| <Styled.BackButton onClick={props.onChangeMode}>취소</Styled.BackButton> | |||
|
|
|||
| <Styled.EditButton>저장</Styled.EditButton> | |||
There was a problem hiding this comment.
p2: 저장버튼은 form submit 용이면 option에 type="submit" 이런걸 넣어주는게 좋습니다
back button은 반대로 form submit 을 안하니까 type="button" 으로 지정해줍시다.
minjj0905
added
🛠 Developing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
버그라 하기도 애매한... 기능 추가가 맞는 듯