Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment: terms only supported in account 1 #42

Open
jonespm opened this issue Dec 19, 2023 · 0 comments
Open

Comment: terms only supported in account 1 #42

jonespm opened this issue Dec 19, 2023 · 0 comments
Labels
📖 documentation Improvements or additions to documentation

Comments

@jonespm
Copy link
Member

jonespm commented Dec 19, 2023

The account ID 1 is hardcoded here which looks like a bug, but if you pass another term ID it returns an error so this is actually correct.

I'd add a comment in the code describing why this hardcoded 1 value was used.

tool-migration/migration/manager.py

Line 47 in cd7db6d

results = await self.api.get(f'/accounts/1/terms')

@lsloan lsloan added the 📖 documentation Improvements or additions to documentation label Dec 19, 2023
@lsloan lsloan changed the title Add a comment here that terms are only supported in the root account Comment: terms only supported in account 1 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📖 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lsloan @jonespm