Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak replacement logic and logging per requirements #10

Open
ssciolla opened this issue Jul 7, 2023 · 0 comments
Open

Tweak replacement logic and logging per requirements #10

ssciolla opened this issue Jul 7, 2023 · 0 comments
Labels
🆕 enhancement New feature or request

Comments

@ssciolla
Copy link
Contributor

ssciolla commented Jul 7, 2023

We discussed some scenarios with the tool tab replacement and defined the following requirements:

  • What should happen if the source tool is already hidden?
    • No replacement action needed
  • What should happen if the target tool is already available?
    • No action needed
  • What should happen if both tools are on the site?
    • Hide the source tool, and it will be deleted in the future
  • What happens if we roll back?
    • Log courses where both tools are enabled?
@ssciolla ssciolla added the 🆕 enhancement New feature or request label Jul 7, 2023
@ssciolla ssciolla mentioned this issue Jul 7, 2023
Merged
ssciolla added a commit that referenced this issue Jul 13, 2023
@ssciolla
Tweak replacement logic to meeting requirements, add reproducible tes…
ec73308 
…ts (#8, #10) (#11)

* Add first draft of reworked logic for replacement

* Return tuple from replace_tool_tab; add reproducible tests for each possible state permutation

* Reuse course; remove old term ID usage, add placeholder value since it is not used

* Downgrade skipping logs to DEBUG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🆕 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ssciolla