Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTI, investigate: JWKS, LTIException, and scope updates #1441

Open
3 tasks
lsloan opened this issue Sep 19, 2022 · 0 comments
Open
3 tasks

LTI, investigate: JWKS, LTIException, and scope updates #1441

lsloan opened this issue Sep 19, 2022 · 0 comments
Labels

Comments

@lsloan
Copy link
Member

lsloan commented Sep 19, 2022

Originally posted by @lsloan in #1421 (comment)

Following a discussion in Slack (see PDF here or in Google Drive), the PR for #1387 was reverted because Canvas requires JWKS support even when it's not going to be used.

The intent of #1387 was to remove definition of LTIException, referrals to it, apparently unused JWKS functions, and cleaning up (removing) the LTI scope. It turns out that Canvas requires the JWKS support functions, even though the PR had been approved.

In this issue, investigate and determine whether these things can be done.

  • – Remove JWKS support. Does Canvas really require this, even when it's not used by the application? If the support cannot be removed, can it be reduced to something simple, like returning a dummy value?
  • – Remove LTIException definition. Is this exception definition really necessary? Can it be removed or left uncaught?
  • – Remove the scopes. As was done in PR remove LTIException & referencing functions (iss. #1387) #1421 for the original issue remove the scopes, because they are unneeded.
@lsloan lsloan added the LTI label Sep 19, 2022
@lsloan lsloan changed the title LTI, investigate: JWKS, LTIException, and scope updates LTI, investigate: JWKS, LTIException, and scope updates Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

1 participant