Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for presentation of LTI tools without a Course Navigation placement #198

Open
ssciolla opened this issue Jun 13, 2022 · 0 comments
Open

Comments

@ssciolla
Copy link
Contributor

Right now, we filter out tools that don't have a Tab in the course context with a matching Canvas ID. This results in tools that don't have Course Navigation as a placement getting filtered out. Ideally, these would still be shown but the Add/Remove button on the card would be hidden (and maybe some other kind of label would be present).

I think we could change the filtering to not exclude these, change the LtiToolWithNavSerializer such that it allows for a none value and is more specific about the type of navigation enabled, and then make the button rendering be conditional in the frontend. I'm imagining the serializer would end up having something like this.

# For when it has a Course Navigation placement
{
  course_navigation: {
    enabled: true (or false)
  }
}

# For when it doesn't
{
  course_navigation: null
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant