Skip to content
This repository has been archived by the owner on May 22, 2022. It is now read-only.

Cross compile issue #11

Open
tkawachi opened this issue Jun 19, 2014 · 4 comments
Open

Cross compile issue #11

tkawachi opened this issue Jun 19, 2014 · 4 comments

Comments

@tkawachi
Copy link
Owner

lock.sbt contains scala binary version of scalaVersion configuration. It will be a problem when it comes to cross compiling with +compile.

@bdarfler
Copy link

I love sbt-lock so it makes me quite sad that I cannot use it on my projects that require cross compilation. Any possibility this will be addressed?

@tkawachi
Copy link
Owner Author

thank you for feedback. I'll try to solve it when I have time

@michaelahlers
Copy link

michaelahlers commented Oct 2, 2018

Might try to find time to make a pull-request for this. Proposal: lock files uniquely named for all possible cross compilations, with assignment to dependencyOverrides made conditional by applicable settings (i.e., matching on CrossVersion.partialVersion(scalaVersion.value) with default to Nil). Initially, this would only support Scala, but the pattern could be applied more broadly down the road (for SBT plugins, runtime targets). To illustrate, invoking lock, with scalaVersion := "2.12.7" produces a single lock_scala_2.12.sbt file with a match on Some((2, 12)), while invoking +lock would result in a respective lock for each element of crossScalaVersions (.e.g, lock_scala_2.13.sbt, lock_scala_2.11.sbt). Thoughts?

@tkawachi
Copy link
Owner Author

tkawachi commented Oct 2, 2018

It seems good. Please try to make a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants