Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Add unit test cases for useToastsInternal hook #130

Closed
tjtanjin opened this issue Oct 3, 2024 · 11 comments · Fixed by #247 · May be fixed by #246
Closed

[Task] Add unit test cases for useToastsInternal hook #130

tjtanjin opened this issue Oct 3, 2024 · 11 comments · Fixed by #247 · May be fixed by #246
Assignees
Labels

Comments

@tjtanjin
Copy link
Owner

tjtanjin commented Oct 3, 2024

Task Description:
Currently, we run unit tests using jest which can be found here.

However, the test cases are not yet comprehensive enough and work can be done to cover more grounds. Specifically for this issue, we hope to add test cases for the useToastsInternal hook.

Deliverable(s):
New unit test cases that cover the testing of the useToastsInternal hook.

Additional Context:

  • Hooks API can be found here
  • Existing unit test for hooks can be found here which may serve as a good source for reference.
@manoshatzi
Copy link

I want to give it a try to this one.

@tjtanjin
Copy link
Owner Author

tjtanjin commented Oct 6, 2024

I want to give it a try to this one.

Go for it!

@tjtanjin
Copy link
Owner Author

Hey @manoshatzi! Checking in to see if you're facing any problems working on the issue. Feel free to reach out!

@tjtanjin
Copy link
Owner Author

Hey @manoshatzi! With hacktoberfest drawing closer to the end, I'll be re-opening this issue for others that may be keen in this final stretch. That said, if you're still interested, feel free to open a PR soonest!

@manoshatzi
Copy link

Hey @tjtanjin. Yes do that. So sorry for not have been finish it but I was really too busy and my spare time was really too less.

@anjumnnit
Copy link
Contributor

anjumnnit commented Oct 23, 2024

can you please assign this me? I tried it already. @tjtanjin

@Nandinibajaj16
Copy link
Contributor

@tjtanjin can you assign this to me

@anjumnnit
Copy link
Contributor

can you please assign this me? I tried it already. @tjtanjin

Can you please assign this on the basis of fcfs as I have only one PR left for hackotberfest'24 :)...

@tjtanjin
Copy link
Owner Author

Hey @anjumnnit, I'll assign this issue to you since you requested for it first. I'll keep the PR from @Nandinibajaj16 open in the meantime, in case the issue is left incomplete.

Separately @Nandinibajaj16, I've tagged the PR from you with hacktoberfest-accepted so that your efforts are not wasted. However, as mentioned in the contributing guidelines, the issue should be assigned to you before working on it (FCFS, to avoid conflicts such as this). Hope to seek your understanding!

@Nandinibajaj16
Copy link
Contributor

@tjtanjin My bad didn't see the updates on the issue before raising the PR, it's okay :)

@anjumnnit
Copy link
Contributor

Hey @anjumnnit, I'll assign this issue to you since you requested for it first. I'll keep the PR from @Nandinibajaj16 open in the meantime, in case the issue is left incomplete.

Separately @Nandinibajaj16, I've tagged the PR from you with hacktoberfest-accepted so that your efforts are not wasted. However, as mentioned in the contributing guidelines, the issue should be assigned to you before working on it (FCFS, to avoid conflicts such as this). Hope to seek your understanding!

tysm 😿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants