-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task] Add unit test cases for useSubmitInputInternal hook #136
Comments
I can try this. Please assign. |
Go for it! |
I worked on it but still facing some issue. you can assign it to someone else thankyou. |
@tjtanjin, hello, I'd like to work on this one, if that's ok! |
Go for it! |
I pushed some initial tests for the hook. While I was working on the tests I realized I have a question that I want to clarify before I move any further - how far should I go with the tests? I see that this hook uses values and triggers a lot of other contexts and hooks. So should I write tests for all/some of those calls as well? Below is the list of those
|
Hey @mashazyu! The tests should be scoped to just the logic within the hook itself. For other contexts and hooks that it relies on, those should be mocked (testing for these other parts are done within their own test cases). |
Task Description:
Currently, we run unit tests using jest which can be found here.
However, the test cases are not yet comprehensive enough and work can be done to cover more grounds. Specifically for this issue, we hope to add test cases for the
useSubmitInputInternal
hook.Deliverable(s):
New unit test cases that cover the testing of the
useSubmitInputInternal
hook.Additional Context:
The text was updated successfully, but these errors were encountered: