Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADC Vref as sensor 4 / Add timestamp to mqtt #100

Merged
merged 2 commits into from
Aug 10, 2024

Conversation

Zitt
Copy link
Contributor

@Zitt Zitt commented Aug 9, 2024

Add ADC Vref as sensor 4.
Allows the Vref to be measured and recorded as a constant for more accurate temperature sensor measurements.

Add Timestamp to mqtt messages
for broker and consumers of the data stream to "know" how old the data is on the broker.

Allows the Vref to be measured and recorded as a constant for more accurate
temperature sensor measurments.
for broker and consumers of the data stream to "know" how old the
data is on the broker.
@tjko
Copy link
Owner

tjko commented Aug 9, 2024

@Zitt, thanks! I like the idea of showing/logging the Vref for ADC.

One minor thing is that the new command seems bit confusing, when its under "sensors". Maybe it should be under "SYS" as it is systemwide setting (and not per sensor setting). Perhaps, make it something like SYS:VREFadc.

For the MQTT change, I'd prefer not have spaces in JSON keys to keep things consistent, sso maybe instead of "date time", use "datetime" or "date_time"?

I can take your changes and make some tweaks, or do you want to update the pull request?

@Zitt
Copy link
Contributor Author

Zitt commented Aug 9, 2024

@tjko I'm far from an expert; honestly, this was more of a hack but figured I'd share if it helps the project long term.

The Vref issue came about from the fact that my hardware "change" didn't fully understand how/why you used a 3.0 shunt regulator. I ended up specing a 3.3vref. In hindsight; I'd just change the hardware but given that's the only problem I've found there isn't a large ROI.

So; I'd prefer you make the changes you like in the spirit of your project.

Yes a space in the string is kinda silly I'd vote "datetime" but whatever you think is best.

@tjko tjko merged commit ff230f6 into tjko:main Aug 10, 2024
9 checks passed
@Zitt Zitt deleted the AddTimestamp2MQTT branch August 10, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants